Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor aws middleware to avoid usage of private package #1

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

easyCZ
Copy link
Contributor

@easyCZ easyCZ commented Nov 7, 2024

AWS has removed the private package (in aws/aws-sdk-go-v2#2818) on which this repository depends.

As a fix, this change brings the metrics middleware removed from aws-sdk-go-v2 into this repo, and uses it. The metrics exposed remain the same.

Copy link
Owner

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis merged commit d75cb27 into jonathan-innis:main Nov 19, 2024
@jonathan-innis
Copy link
Owner

Thanks for pulling the changes over @easyCZ!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants