Add the autocomplete plugin #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the official autocomplete plugin which is better than nothing, but not perfect. It supports bash and zsh, so that covers a lot of the cases, but not all. But more than that, it's just going to support autocomplete on the commands themselves, not GitHub usernames, which is probably the bigger win.
I was able to get this to work over on my dotfiles here:
https://github.com/jonallured/dotfiles/blob/655edfe312b972b9a8ab6521b47a728b04b08ce1/rcm/zsh/completions/_pear#L26-L32
But it ain't pretty and I'm certainly open to other ideas!! /cc @ashfurrow
See also #5.