Add prev/next links to reading list #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonallured
force-pushed
the
add-prev-next-links-to-reading-list
branch
from
f104386 to
8032dbc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted a way to navigate between years in the Reading List page but wasn't sure how I was going to do it. I tinkered with add these links conditionally only if the year actually has books but then I realized: I don't really care and it's added complexity for very little benefit. If there aren't books on that year then the table is just empty - who cares?
So then having established that I was always going to have these links show up then my next thought was about how they'd look on the page. I ended up looking at the nav that connects all the style pages and adapted that to this case.
Looks like this: