-
Notifications
You must be signed in to change notification settings - Fork 785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle contentUri in copy function #165
base: master
Are you sure you want to change the base?
Conversation
# Conflicts: # android/build.gradle
👍 would be great to have this (or wkh237#546) merged |
Indeed. @Traviskn, sorry for bothering you directly, but any comments on the PR? Is it just the wrong branch? |
Any updates on this. I would really like to get this merged as it is causing me to use custom install just to get these changes |
apologies for the long overdue review - if we could get the merge conflicts resolved and any testing/confirmation that the updated PR fixes the described issue without breaking anything then we can merge this. |
I haven't tested it, but attempting to translate all content to file paths is a classic Android issue, and this implementation (detecting it's a content:// URI, and just doing InputStream with no attempt to fetch the path) is the correct style.. This code seems like a fair implementation of that idea. Clever to fetch the input stream as a check to make sure it actually exists as well. I'm not familiar with the raw protocol so I won't comment but the code itself seems like a fair enough protocol addition to support it, whatever it is... |
# Conflicts: # android/src/main/java/com/RNFetchBlob/Utils/PathResolver.java
Hey @Traviskn, I have resolved all the merge conflicts. Let me know if anything else needs to be done |
Handling contentUri in copy function for reading URI when it belongs to other app. Since contentUri from other apps cannot be converted to real paths, we only have the option to read the InputStream.
Also, adding one more format in PathResolver for android contentUri which is used by some default apps in newer version of android.