Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle contentUri in copy function #165

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

kkbhav
Copy link

@kkbhav kkbhav commented Aug 28, 2018

Handling contentUri in copy function for reading URI when it belongs to other app. Since contentUri from other apps cannot be converted to real paths, we only have the option to read the InputStream.

Also, adding one more format in PathResolver for android contentUri which is used by some default apps in newer version of android.

@edcuba
Copy link

edcuba commented Nov 14, 2018

👍 would be great to have this (or wkh237#546) merged

@svenstucki
Copy link

Indeed. @Traviskn, sorry for bothering you directly, but any comments on the PR? Is it just the wrong branch?

@kkbhav
Copy link
Author

kkbhav commented Dec 31, 2018

Any updates on this. I would really like to get this merged as it is causing me to use custom install just to get these changes

@Traviskn
Copy link

apologies for the long overdue review - if we could get the merge conflicts resolved and any testing/confirmation that the updated PR fixes the described issue without breaking anything then we can merge this.

@Traviskn Traviskn added the help wanted Extra attention is needed label Sep 26, 2019
@mikehardy
Copy link

I haven't tested it, but attempting to translate all content to file paths is a classic Android issue, and this implementation (detecting it's a content:// URI, and just doing InputStream with no attempt to fetch the path) is the correct style..

This code seems like a fair implementation of that idea. Clever to fetch the input stream as a check to make sure it actually exists as well.

I'm not familiar with the raw protocol so I won't comment but the code itself seems like a fair enough protocol addition to support it, whatever it is...

# Conflicts:
#	android/src/main/java/com/RNFetchBlob/Utils/PathResolver.java
@kkbhav
Copy link
Author

kkbhav commented Sep 30, 2019

Hey @Traviskn, I have resolved all the merge conflicts. Let me know if anything else needs to be done

cguino pushed a commit to BeApp/rn-fetch-blob that referenced this pull request Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants