Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix has_metadata_value and has_shape result #51

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nkzawa
Copy link

@nkzawa nkzawa commented Nov 27, 2022

Description

This PR fixes model.has_metadata_value() and model.has_shape() returns an opposite result.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Environment (please complete the following information):

  • Platform: [e.g.uname -a]
  • Rust [e.g.rustic -vV]
  • Cargo [e.g.cargo -vV]

Checklist:

  • My code follows the style guidelines of this project (e.g. run cargo fmt)
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • My changes DO NOT require unstable features without prior agreement
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant