Improve Acceptance Tests workflow #94
Conversation
| fi | ||
| env: | ||
| WP_CORE_CONSTRAINT: ${{ matrix.wp == 'nightly' && 'dev-main' || format('~{0}.0', matrix.wp) }} | ||
| uses: ramsey/composer-install@v2 |
There was a problem hiding this comment.
Why do I need to use a third party action for this?
There was a problem hiding this comment.
As this action does caching, composer install or composer update, handles timeout, output and more.
Please see it running.
Viktor uses it in dozens of projects.
There was a problem hiding this comment.
You must know Ben!
There was a problem hiding this comment.
Alternatively you could have own workflows in community health files https://github.com/ergebnis/.github/tree/main/actions/composer
e.g. https://github.com/ergebnis/php-package-template/blob/main/.github/workflows/integrate.yaml#L42-L55
There was a problem hiding this comment.
@johnbillion Would you merge something based on plugin-infrastructure?
There was a problem hiding this comment.
Not just yet, thanks Viktor. I'm making my way through a list of to-do items as I find the the time and based on the similar but not identical testing setup that I have across my plugins.
There was a problem hiding this comment.
I'd like to promote Ben's action.
|
Closing this off now #110 is in. Thanks Viktor! |
|
Glad to contribute to John-projects. |
The temptation!
ramsey/composer-installaction