Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alternate sunrise sunset face #483

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

mcguirepr89
Copy link
Contributor

@mcguirepr89 mcguirepr89 commented Oct 16, 2024

This is just an alternate face to the sunrise sunset face that adds in civil and nautical twilight. There was also a lot of code refactoring to make it make more sense to me as I tinkered with this.

PS
I'm very excited for movement 2.0

PPS
I'm also planning to add an EVENT_ALARM_LONG_PRESS eventually that will allow the user to set these different solar events as alarms (to enjoy a sunrise/sunset or to be otherwise notified when the outside darkness has reached the civil twilight threshold).

F91w_exampleface-2024-10-19_07.15.58.mp4

For this video, I set the clock to really early to show the solar events for an entire day. Then I reset the time to show that when the solar event has passed for the day, the event gets put at the bottom of the loop, so you can see the time event times for the next day for any event that has passed.

@mcguirepr89
Copy link
Contributor Author

I just realized that my PR replaced the original -- let me fix that!

@mcguirepr89
Copy link
Contributor Author

mcguirepr89 commented Oct 21, 2024

Wasn't running on hardware, then I realized I had full int ranges in a few places, so I fixed that memory guzzle -- so I can say that this has been tested on hardware and is working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant