-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding really long press for each button #457
base: main
Are you sure you want to change the base?
Conversation
Thank you for your contribution! Movement will soon be refactored in preparation for the new sensor watch board release. For that reason, it was decided to postpone the merging of changes which touch the core of the framework. We hope to revisit this proposal after movement 2.0 is released. |
The TOTP face header file documentation contained outdated instructions for configuring the complication with TOTP credentials. This PR updates the documentation to match what is expected in `totp_face.c`.
This reverts commit 7d5aaf6.
…an just ignoring new presses after Xms
…the rthan dact after a set amount of time due to an issue of delay_ms allowing a shoft-bricking
…faults the mode to 24Hr mode
…clock faces for DCE
Ugh rebasing is a pain in the butt and I'm obviously not very good at it. I suppose we'll look at this again when the time is right. If things get too messy, I can always resubmit this as a clean PR with only the changes to |
Chiming in to say I think this is a great idea - especially the parity-with-Casio part! That screen ('Sensor') would also be a great place to display some firmware ID strings: build date, version, git hash, builder-specified, etc. |
I don't expect this to be pulled into
main
anytime soon (if ever), but I wanted to flag it for the maintainers and folks who are paying close attention to this repo because I have found it increasingly useful to have another set of button events for each button for my own faces.All this does is adds an "EVENT_*_REALLY_LONG_{PRESS,UP}" for each button in the movement framework. Of course, for faces that currently utilize the "EVENT_*LONG_*" events, I've had to do a little tinkering, namely shifting "EVENT_*_LONG_PRESS" events into "EVENT_*_LONG_UP" events, but for me, it has been worth it to have the extra events at my disposal.
Specifically for the Sensor-Watch to have cheeky branding parity with the original Casio, holding the ALARM for the "EVENT_ALARM_REALLY_LONG_PRESS" can show "SENSOR" in the way that the original Casio shows "CASIO". I've implemented this for my local watch club in some edits to the
repetition_minute_face
to display "WC DMV," (as in the DistrictMarylandVirginia Watch Club) -- see the code hereAnd, as another example, my kegging helper face (I work at a brewery and often need to keep track of when beer kegging chemicals need changing): header and source
And just for fun while we're on beer!!!!: beer-o-clock source and beer-o-clock header -- thanks @WesleyAC !
Thanks again for everything and feel free to close this as soon as you'd like!
My best,
Patrick