Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call set_time_face on long press of alarm. Move alert toggle to light. #456

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

TonyHoyle
Copy link

Since we were talking about this :)

Instead of trying to merge the functionality into every watch face that might need it, I simply call the set_time_face directly on long press of alarm.

I've moved the alert functionality onto long press of light.

Tested on the simulator.. seems to work fine. I did watch_face first then realized I was using simple_watch_face too but the changes are not large.

It would be nice if there was a formal way for faces to call complications/settings like this, but this works.

@matheusmoreira
Copy link
Collaborator

Thank you for your contribution. The highest priority right now is the upcoming movement 2.0 refactor in preparation for the release of the new sensor watch pro board. Changes which touch the user interface changes will be considered after it is done.

Instead of trying to merge the functionality into every watch face that might need it

It would be nice if there was a formal way for faces to call complications/settings like this

You're correct about that. I too would like to improve this. I feel like there is a lot of duplicated functionality in between the numerous watch faces.

One of the purposes of movement's refactoring is to pay off tech debt. I plan to make contributions towards this end once the movement refactoring is under way. I encourage you to help out as well!

@matheusmoreira matheusmoreira added the 2.0-wait-list This feature or pull requests has been deferred until the movement 2.0 refactor is complete label Sep 3, 2024
@TonyHoyle TonyHoyle force-pushed the set_time_on_alarm_press branch from 61fdbaa to cbebf73 Compare September 3, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0-wait-list This feature or pull requests has been deferred until the movement 2.0 refactor is complete
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants