Add some values to the chart #97
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oliver Bähler <[email protected]>
|
@oliverbaehler thanks for this addition, but we just upped the major version of the helm chart to add support for daemonsets. If you can rebase on top of the latest, I would be glad to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Oliver Bähler [email protected]
I have added some values to the chart which would help me deploy cert-exporter easier:
.Values.certManagerDeployment.deployment.podLabels: Allows to add labels to the pod.Values.certManagerDeployment.deployment.env: Allows to add env variables to the container.Values.certManagerDeployment.service.serviceMonitor.podTargetLabels: Allows scraping of additional labelsBumped version to
2.8.0