Changing the top CSS value within base.toggleHeaders from 0 to newTop… #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhyland87
commented
Feb 5, 2018
| @@ -166,7 +166,7 @@ | |||
| base.$originalHeader.css({ | |||
| 'position': 'fixed', | |||
| 'margin-top': base.options.marginTop, | |||
| 'top': 0, | |||
There was a problem hiding this comment.
Not sure why this is set to 0. It just seems to cause problems with the table header "flickering" as it switches back and fourth between 0 and the newTopOffset value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed resolution to Issue #107.
When viewing the table header in FireFox Inspector, I notice the CSS top value within the style attribute of the thead.tableFloatingHeaderOriginal element will very quickly switch back and fourth between 0px and the value defined by the
newTopOffsetvariable. Changing the CSS top to usenewTopOffsetseems to fix the problem in FireFox, Chrome and IE.