Don't assume that the benchmark won't flush the message queue #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eministat:s_warmup/1 schedules the sending of a 'warmup_over' message to self() to stop warmup after 3 seconds. If the benchmarked function flushes the message queue, the message can be lost and warmup go on indefinitely. This patch changes s_warmup/1 to not rely on message sending, instead s_warmup/1 remembers when it started and terminates the warmup loop when 3s have elapsed.
fenollp
approved these changes
Apr 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eministat:s_warmup/1 schedules the sending of a 'warmup_over' message
to self() to stop warmup after 3 seconds. If the benchmarked function
flushes the message queue, the message can be lost and warmup go on
indefinitely.
This patch changes s_warmup/1 to not rely on message sending, instead
s_warmup/1 remembers when it started and terminates the warmup loop
when 3s have elapsed.