Skip to content

Commit

Permalink
Removed the Oracle Cloud Infrastructure DNS DNS plugin, because it …
Browse files Browse the repository at this point in the history
…breaks certbot.
  • Loading branch information
jlesage committed Aug 4, 2023
1 parent 87adde3 commit aa9fdfd
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 0 deletions.
1 change: 1 addition & 0 deletions src/nginx-proxy-manager/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ sed -i "s/\"version\": \"0.0.0\",/\"version\": \"${NGINX_PROXY_MANAGER_VERSION}\

log "Patching Nginx Proxy Manager backend..."
patch -p1 -d /tmp/nginx-proxy-manager < "$SCRIPT_DIR"/pip-install.patch
patch -p1 -d /tmp/nginx-proxy-manager < "$SCRIPT_DIR"/remove-certbot-dns-oci.patch

cp -r /tmp/nginx-proxy-manager /app

Expand Down
25 changes: 25 additions & 0 deletions src/nginx-proxy-manager/remove-certbot-dns-oci.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
Because of the Oracle Cloud Infrastructure DNS plugin dependencies, installing
it causes certbot to be downgraded, which then break any execution of certbot.
--- a/global/certbot-dns-plugins.js
+++ b/global/certbot-dns-plugins.js
@@ -437,20 +437,6 @@ dns_netcup_api_password = abcdef0123456789abcdef01234567abcdef0123`,
full_plugin_name: 'dns-nsone',
},
//####################################################//
- oci: {
- display_name: 'Oracle Cloud Infrastructure DNS',
- package_name: 'certbot-dns-oci',
- package_version: '0.3.6',
- dependencies: 'oci',
- credentials: `[DEFAULT]
-user = ocid1.user.oc1...
-fingerprint = xx:xx:xx:xx:xx:xx:xx:xx:xx:xx:xx:xx:xx
-tenancy = ocid1.tenancy.oc1...
-region = us-ashburn-1
-key_file = ~/.oci/oci_api_key.pem`,
- full_plugin_name: 'dns-oci',
- },
- //####################################################//
online: {
display_name: 'Online',
package_name: 'certbot-dns-online',

0 comments on commit aa9fdfd

Please sign in to comment.