remove SimpleUnpack and usages of @unpack

jlchan · May 21, 2024 · 192c7d0 · 192c7d0
1 parent dcac38d
commit 192c7d0
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 5 deletions.
diff --git a/Project.toml b/Project.toml
@@ -17,7 +17,6 @@ RecursiveArrayTools = "731186ca-8d62-57ce-b412-fbd966d074cd"
 Reexport = "189a3867-3050-52da-a836-e630ba90ab69"
 Requires = "ae029012-a4dd-5104-9daa-d747884805df"
 Setfield = "efcf1570-3423-57d1-acb7-fd33fddbac46"
-SimpleUnPack = "ce78b400-467f-4804-87d8-8f486da07d0a"
 SparseArrays = "2f01184e-e22b-5df5-ae63-d93ebab69eaf"
 StaticArrays = "90137ffa-7385-5640-81b9-e52037218182"
 Triangulate = "f7e6ffb2-c36d-4f8f-a77e-16e897189344"
@@ -41,7 +40,6 @@ RecursiveArrayTools = "3"
 Reexport = "1"
 Requires = "1"
 Setfield = "1"
-SimpleUnPack = "1"
 SparseArrays = "1"
 StaticArrays = "1"
 SummationByPartsOperators = "0.5.52"

diff --git a/src/StartUpDG.jl b/src/StartUpDG.jl
@@ -17,7 +17,6 @@ using RecipesBase: RecipesBase
 @reexport using RecursiveArrayTools: NamedArrayPartition
 using StaticArrays: SVector, SMatrix
 using Setfield: setproperties, @set # for "modifying" structs (setproperties)
-@reexport using SimpleUnPack: @unpack
 using SparseArrays: sparse, droptol!, blockdiag
 using Triangulate: Triangulate, TriangulateIO, triangulate
 @reexport using WriteVTK

diff --git a/src/mesh/gmsh_utilities.jl b/src/mesh/gmsh_utilities.jl
@@ -103,7 +103,7 @@ Notes: the version 4 format has a more detailed block data format
 this leads to more complicated parser.
 """
 function read_Gmsh_2D_v4(filename::String, options::MeshImportOptions)
-    @unpack grouping, remap_group_name = options
+    (; grouping, remap_group_name) = options
 
     if !isfile(filename)
         throw(ArgumentError("file $filename does not exist"))

diff --git a/test/reference_elem_tests.jl b/test/reference_elem_tests.jl
@@ -273,7 +273,7 @@ inverse_trace_constant_compare(rd::RefElemData{3, <:Wedge, <:TensorProductWedge}
         @test abs(sum(rd.wf .* rd.nsJ)) < tol
         @test abs(sum(rd.wf .* rd.ntJ)) < tol
 
-        @unpack node_ids_by_face = rd.element_type
+        (; node_ids_by_face) = rd.element_type
         @test sum(rd.wf[node_ids_by_face[1]]) ≈ 4
         # Note: this is not the true area of face 2. Because we map 
         # all faces back to the reference face, there is a factor of