Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mypy's worries that exc.response may be None #617

Closed

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Nov 14, 2023

https://github.com/jjjake/internetarchive/actions are currently failing because mypy is worried that exc.response could be None. Let's fix that to placate mypy and add 1 line to our max statements limit so that pre-commit tests are green again ✅ .

Note that pre-commit autoupdate should be run in a separate pull request to upgrade our linting tools. This should be done every few months or automated by enabling https://pre-commit.ci as is done in Open Library.

% pre-commit autoupdate

[https://github.com/pre-commit/pre-commit-hooks] updating v4.4.0 -> v4.5.0
[https://github.com/charliermarsh/ruff-pre-commit] updating v0.0.269 -> v0.1.5
[https://github.com/psf/black] updating 23.3.0 -> 23.11.0
[https://github.com/codespell-project/codespell] updating v2.2.4 -> v2.2.6
[https://github.com/pre-commit/mirrors-mypy] updating v1.3.0 -> v1.7.0
[https://github.com/asottile/setup-cfg-fmt] updating v2.2.0 -> v2.5.0

@cclauss cclauss closed this Dec 28, 2023
@cclauss cclauss deleted the fix-mypy-exc.response.content-errors branch December 28, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant