Fix mypy's worries that exc.response may be None #617
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/jjjake/internetarchive/actions are currently failing because
mypy
is worried thatexc.response
could beNone
. Let's fix that to placatemypy
and add 1 line to our max statements limit so that pre-commit tests are green again ✅ .Note that
pre-commit autoupdate
should be run in a separate pull request to upgrade our linting tools. This should be done every few months or automated by enabling https://pre-commit.ci as is done in Open Library.%
pre-commit autoupdate