-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP fix derive logic and redundant hash calc #351
base: master
Are you sure you want to change the base?
Conversation
Related: #252 This would be nice to have in general. I wrote a script for myself last year since I didn't want to click around on the web interface all the time as I'm using |
Yes, it's possible to queue a derive task without uploading anything:
Python:
|
Great, I will use this instead of the counting logic. |
I removed all counting logic and just call derive() in the end. Do you think that is an acceptable solution? |
No, I think the derive task should still be queued in the upload request. I'd like to avoid submitting an extra request to another API if possible. |
Could this be added to the documentation? It only mentions |
f51111a
to
4e786b6
Compare
4e786b6
to
477e48f
Compare
90ff2e3
to
acfeed5
Compare
71e202f
to
4c453f3
Compare
4c453f3
to
e96d2bb
Compare
removed all counting whatsoever and just queue the derive in the end
What's the status of this? |
@soredake jjjake didn't like the approach to have a seperate API call to queue the derive. Also at the time the unittests failed for some reason. I haven't looked at this PR for the past few years and now there are merge conflicts. |
This addresses #253 and #288
Counts all files (even those which might be skipped). This is consistent with the newly added behavior for file-level metadata.
BUG: if the last file is skipped, then a derive is never queued
Any idea how to solve this? Is there a way to queue a derive WITHOUT uploading a file?
The easiest way would be to just upload everything and skip whatever you like, and then after everything is completed, simple do queue a derive with a separate call.
Then we could do away with this fragile file counting.