Fix SIGPIPE bug that broke CLI on non-unix systems

jjjake · Nov 8, 2024 · b59c99e · b59c99e
1 parent ebbfce6
commit b59c99e
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 3 deletions.
diff --git a/HISTORY.rst b/HISTORY.rst
@@ -3,6 +3,13 @@
 Release History
 ---------------
 
+5.0.1 (?)
++++++++++
+
+**Bugfixes**
+
+- Fix bug where the use of signal.SIGPIPE causes the CLI to crash on Windows (SIGPIPE is not available on Windows).
+
 5.0.0 (2024-11-07)
 ++++++++++++++++++
 

diff --git a/internetarchive/__version__.py b/internetarchive/__version__.py
@@ -1 +1 @@
-__version__ = '5.0.0'
+__version__ = '5.0.1.dev'
diff --git a/internetarchive/cli/ia.py b/internetarchive/cli/ia.py
@@ -41,8 +41,12 @@
 from internetarchive.cli.cli_utils import exit_on_signal
 
 # Handle <Ctrl-C> and broken pipe
-signal.signal(signal.SIGPIPE, signal.SIG_DFL)
-signal.signal(signal.SIGINT, exit_on_signal)
+try:
+    signal.signal(signal.SIGPIPE, signal.SIG_DFL)
+    signal.signal(signal.SIGINT, exit_on_signal)
+except AttributeError:
+    # Non-unix support
+    pass
 
 
 def validate_config_path(path):