Merge pull request #659 from jjjake/windows-sigpipe-fix

Fix SIGPIPE bug that broke CLI on non-unix systems
jjjake · Nov 8, 2024 · 201369a · 201369a
2 parents ebbfce6 + 109c996
commit 201369a
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 3 deletions.
diff --git a/HISTORY.rst b/HISTORY.rst
@@ -3,6 +3,13 @@
 Release History
 ---------------
 
+5.0.1 (?)
++++++++++
+
+**Bugfixes**
+
+- Fix bug where the use of signal.SIGPIPE causes the CLI to crash on Windows (SIGPIPE is not available on Windows).
+
 5.0.0 (2024-11-07)
 ++++++++++++++++++
 

diff --git a/internetarchive/__version__.py b/internetarchive/__version__.py
@@ -1 +1 @@
-__version__ = '5.0.0'
+__version__ = '5.0.1.dev'
diff --git a/internetarchive/cli/ia.py b/internetarchive/cli/ia.py
@@ -40,8 +40,14 @@
 )
 from internetarchive.cli.cli_utils import exit_on_signal
 
-# Handle <Ctrl-C> and broken pipe
-signal.signal(signal.SIGPIPE, signal.SIG_DFL)
+# Handle broken pipe
+try:
+    signal.signal(signal.SIGPIPE, signal.SIG_DFL)
+except AttributeError:
+    # Non-unix support
+    pass
+
+# Handle <Ctrl-C>
 signal.signal(signal.SIGINT, exit_on_signal)