Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add playlist creation, deletion, export and import #105

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

laurentperez
Copy link

Hi

Like several owners, I have lost playlists due to factory resets. So I found your great project and added some useful code. I will PR on node-sonos-http-api too to reflect the new features.

  • I have one test currently failing for playlist import (see npm test) because I don't know how to mock the browse response. @jishi I need your help on this one. AddUriToSavedQueue requires multiple synchronized Browse calls and I don't know how to mock them. The code is running fine, the test isn't passing because my lack of sinon knowledge.
  • I bumped the version to 1.4.2 because of the future PR on node-sonos-http-api. Maybe you want to stay on 1.4.1.

@laurentperez
Copy link
Author

laurentperez commented Jun 11, 2017

for reference tracking test also fails because of #104

@laurentperez
Copy link
Author

@jishi any chance you may have a look at the sinon mocked browse part ?

@jishi
Copy link
Owner

jishi commented Jun 30, 2017

Sorry, had forgotten about this and been busy. Starting vacation today, so hopefully I will have some time for my side projects soon :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants