Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[style] 로그인 페이지 bottom fixed 버튼 스타일 제거 #187

Merged
merged 1 commit into from
May 2, 2024
Merged

[style] 로그인 페이지 bottom fixed 버튼 스타일 제거 #187

merged 1 commit into from
May 2, 2024

Conversation

Ssoon-m
Copy link
Collaborator

@Ssoon-m Ssoon-m commented May 1, 2024

구현한 것

  • 로그인 페이지의 bottom fixed 버튼 스타일을 제거했습니다.
  • ios앱에서 focus시 button 숨김처리되는 로직을 제거했습니다.

구현하지 않은 것

  • 회원가입 페이지 등에서 input이 하나만 존재하는 ui는 bottom fixed를 그대로 유지했습니다.

동작 확인

2024-05-01.1.54.01.mov

@Ssoon-m Ssoon-m changed the title style: delete bottom fixed [style] 로그인 페이지 bottom fixed 버튼 스타일 제거 May 1, 2024
@Ssoon-m Ssoon-m requested a review from tolluset May 1, 2024 04:56
@Ssoon-m Ssoon-m linked an issue May 1, 2024 that may be closed by this pull request
[fix] 앱에서 키패드 올라올 때 이슈 #176
Closed
@Ssoon-m Ssoon-m self-assigned this May 1, 2024
tolluset
tolluset approved these changes May 1, 2024
View reviewed changes
Copy link
Collaborator

@tolluset tolluset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

심플해졌네영! 확실히 이게 나은거같네영 👍👍👍

@Ssoon-m Ssoon-m merged commit 2354224 into main May 2, 2024
@Ssoon-m Ssoon-m deleted the fix/176/app-keypad branch May 2, 2024 12:16
tjsry0466 pushed a commit that referenced this pull request May 3, 2024
@Ssoon-m @tjsry0466
[style] 로그인 페이지 bottom fixed 버튼 스타일 제거 (#187)
bf4bcdc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tolluset tolluset tolluset approved these changes

Assignees

@Ssoon-m Ssoon-m

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[fix] 앱에서 키패드 올라올 때 이슈
2 participants
@Ssoon-m @tolluset