Skip to content

Commit

Permalink
sortof remove sleep, but need it because of RHOAIENG-15907
Browse files Browse the repository at this point in the history
  • Loading branch information
jiridanek committed Nov 24, 2024
1 parent 5f440a1 commit 561616a
Showing 1 changed file with 4 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,6 @@ var _ = Describe("The Openshift Notebook controller", func() {
By("By creating a new Notebook")
notebook := createNotebook(Name, Namespace)
Expect(cli.Create(ctx, notebook)).Should(Succeed())
time.Sleep(interval)

By("By checking that trusted-ca bundle is mounted")
// Assert that the volume mount and volume are added correctly
Expand Down Expand Up @@ -309,6 +308,8 @@ var _ = Describe("The Openshift Notebook controller", func() {
// Check the content in workbench-trusted-ca-bundle matches what we expect:
// - have 2 certificates there in ca-bundle.crt
// - both certificates are valid
// TODO(RHOAIENG-15907): adding sleep to reduce flakiness
time.Sleep(2 * time.Second)
configMapName := "workbench-trusted-ca-bundle"
checkCertConfigMap(ctx, notebook.Namespace, configMapName, "ca-bundle.crt", 2)
})
Expand Down Expand Up @@ -379,7 +380,6 @@ var _ = Describe("The Openshift Notebook controller", func() {
updatedImage := "registry.redhat.io/ubi8/ubi:updated"
notebook.Spec.Template.Spec.Containers[0].Image = updatedImage
Expect(cli.Update(ctx, notebook)).Should(Succeed())
time.Sleep(interval)

By("By checking that trusted-ca bundle is mounted")
// Assert that the volume mount and volume are added correctly
Expand Down Expand Up @@ -412,6 +412,8 @@ var _ = Describe("The Openshift Notebook controller", func() {
// Check the content in workbench-trusted-ca-bundle matches what we expect:
// - have 2 certificates there in ca-bundle.crt
// - both certificates are valid
// TODO(RHOAIENG-15907): adding sleep to reduce flakiness
time.Sleep(2 * time.Second)
configMapName := "workbench-trusted-ca-bundle"
checkCertConfigMap(ctx, notebook.Namespace, configMapName, "ca-bundle.crt", 2)
})
Expand Down

0 comments on commit 561616a

Please sign in to comment.