cleanup

jinlow · Dec 13, 2023 · 7c6595b · 7c6595b
1 parent 413f520
commit 7c6595b
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/src/gradientbooster.rs b/src/gradientbooster.rs
@@ -1100,6 +1100,13 @@ impl GradientBooster {
         self
     }
 
+    /// Set the max_delta_step on the booster.
+    /// * `max_delta_step` - The max_delta_step value of the booster.
+    pub fn set_max_delta_step(mut self, max_delta_step: f32) -> Self {
+        self.max_delta_step = max_delta_step;
+        self
+    }
+
     /// Set the min_leaf_weight on the booster.
     /// * `min_leaf_weight` - The minimum sum of the hession values allowed in the
     ///     node of a tree of the booster.

diff --git a/src/histogram.rs b/src/histogram.rs
@@ -150,15 +150,13 @@ impl HistogramMatrix {
             col_index
                 .par_iter()
                 .flat_map(|col| {
-                    let h = create_feature_histogram(
+                    create_feature_histogram(
                         data.get_col(*col),
                         cuts.get_col(*col),
                         &sorted_grad,
                         &sorted_hess,
                         index,
-                    );
-                    //ends[*col] = h.len();
-                    h
+                    )
                 })
                 .collect::<Vec<Bin<f32>>>()
         } else {