Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
net/rose: fix NULL ax25_cb kernel panic
When an internally generated frame is handled by rose_xmit(), rose_route_frame() is called: if (!rose_route_frame(skb, NULL)) { dev_kfree_skb(skb); stats->tx_errors++; return NETDEV_TX_OK; } We have the same code sequence in Net/Rom where an internally generated frame is handled by nr_xmit() calling nr_route_frame(skb, NULL). However, in this function NULL argument is tested while it is not in rose_route_frame(). Then kernel panic occurs later on when calling ax25cmp() with a NULL ax25_cb argument as reported many times and recently with syzbot. We need to test if ax25 is NULL before using it. Testing: Built kernel with CONFIG_ROSE=y. Signed-off-by: Bernard Pidoux <[email protected]> Acked-by: Dmitry Vyukov <[email protected]> Reported-by: [email protected] Cc: "David S. Miller" <[email protected]> Cc: Ralf Baechle <[email protected]> Cc: Bernard Pidoux <[email protected]> Cc: [email protected] Cc: [email protected] Cc: [email protected] Signed-off-by: David S. Miller <[email protected]>
- Loading branch information