Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update volume paths in docker-compose.yaml #416

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

cr1ma
Copy link
Contributor

@cr1ma cr1ma commented Dec 5, 2024

Related issues / PRs. Summarize issues.

  • N/A

Summarize Changes

  1. Updated docker-compose.yaml to use relative paths for model and output directories:
    - ./models:/Whisper-WebUI/models
    - ./outputs:/Whisper-WebUI/outputs
    Previously:
    - /Whisper-WebUI/models
    - /Whisper-WebUI/outputs

Why is this better?

  1. Simplified Model Management:
    • Models can be managed directly from the local models directory.
  2. Faster Container Startup:
    • Models are not reloaded with every container start.
  3. Improved UX:
    • Users can easily work with ./models and ./outputs without additional configuration.
  4. Enhanced Flexibility:
    • Local directories allow straightforward customization and modification of models and results.

Impact

  • Maintains backward compatibility.
  • No additional dependencies or configurations are required.
  • Improves efficiency, flexibility, and user satisfaction.

- Updated volume paths in `docker-compose.yaml` to use relative paths (`./models` and `./outputs`) for easier configuration.
- Added comments to guide users on placing models and accessing output files.
@jhj0517
Copy link
Owner

jhj0517 commented Dec 6, 2024

Thanks!
Since it's recommended to run container with compose, and most users will probably run docker compose up within the Whipser-WebUI project, I think it's appropriate to mount paths like this by default.

I'll merge soon after some testing!

@jhj0517 jhj0517 merged commit 0652709 into jhj0517:master Dec 6, 2024
6 checks passed
@jhj0517 jhj0517 added the enhancement New feature or request label Dec 6, 2024
@cr1ma cr1ma deleted the refactor/optimize-docker-compose branch December 6, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants