Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include loading of default value of file_format from config file. #380

Merged
merged 3 commits into from
Nov 4, 2024
Merged

Include loading of default value of file_format from config file. #380

merged 3 commits into from
Nov 4, 2024

Conversation

linuxlurak
Copy link
Contributor

Related issues / PRs

Summarize Changes

Include loading of default value of file_format from config file.

@linuxlurak
Update default_parameters.yaml
3f330f0 
Including file_format.
@linuxlurak
Update app.py
8a43431 
Including file_format loading from default config.
@jhj0517
Copy link
Owner

jhj0517 commented Nov 4, 2024

Thanks for this.
OK, let me take care of some bugs on restart myself, because it allows edits PR by maintainers.
Without forcing push this time.. 😅

@jhj0517
Copy link
Owner

jhj0517 commented Nov 4, 2024 •
edited
Loading

All tested and worked fine, merging it!
Thanks!

@jhj0517 jhj0517 merged commit e9891d2 into jhj0517:master Nov 4, 2024
6 checks passed
@jhj0517 jhj0517 added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhj0517 jhj0517 jhj0517 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@linuxlurak @jhj0517