Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable word timestamps #366

Merged
merged 30 commits into from
Oct 31, 2024
Merged

Enable word timestamps #366

merged 30 commits into from
Oct 31, 2024

Conversation

jhj0517
Copy link
Owner

@jhj0517 jhj0517 commented Oct 31, 2024 •
edited
Loading

Related issues / PRs

Summarize Changes

  1. Enabled word_timestamps
  2. Added lrc (Song Lyrics) subtitle format
  3. Refactor to subtitle writer utils
  4. Fixed VAD bug
  5. Fixed wrong max_initial_timestamp default from 0 to 1 ( This caused messing up the segment length )
  6. Raise error thatn just printing

jhj0517 added 27 commits October 30, 2024 18:30
@jhj0517
Wrap faster-whisper Segment to with fastapi's.
6f022af
@jhj0517
clean imports
b88d9c4
@jhj0517
Add factory function
6c42d0c
@jhj0517
Fix return type
e0e906d
@jhj0517
Updated docstring
c0bbe98
@jhj0517
Add file writer classes
9cf3b54
@jhj0517
Fix format and add add_timestamp
0036278
@jhj0517
Add read_file()
0c6f6c3
@jhj0517
Fix default value of the words
60840eb
@jhj0517
Fix default value of the words
a377305
@jhj0517
Use generate_file()
a1b32c1
@jhj0517
Refactor translation
79e6f08
@jhj0517
Fix translation fields
97bde30
@jhj0517
Fix translation fields
aa24086
@jhj0517
Fix deprecated syntax
b9aca0f
@jhj0517
Fix wrong empty words check logic
c98fbfc
@jhj0517
Fix syntax
9215083
@jhj0517
Fix adding timestamp
500f983
@jhj0517
Wrap Word data class
d8a7425
@jhj0517
Enable writer options
320b77a
@jhj0517
Use wirter options to highlight
482e6f7
@jhj0517
Add lrc writer
e76bbe3
@jhj0517
Add lrc extension
3b27598
@jhj0517
Add lrc word aligning feature
79d567a
@jhj0517
Fix default
21e9b06
@jhj0517
Refactor to raise error
46f7c1b
@jhj0517
Fix type issue
2efa275
@jhj0517
Copy link
Owner Author

jhj0517 commented Oct 31, 2024

The failed test is about pytubefix being detected as a bot.

@jhj0517 jhj0517 merged commit 1a63918 into master Oct 31, 2024
3 of 6 checks passed
@jhj0517 jhj0517 mentioned this pull request Oct 31, 2024
Closed
@jhj0517 jhj0517 linked an issue Oct 31, 2024 that may be closed by this pull request
Word-by-word timing would be perfect for karaoke #362
Closed
@jhj0517 jhj0517 mentioned this pull request Nov 1, 2024
Merged
@jhj0517 jhj0517 deleted the feature/enable-word-timestamps branch November 9, 2024 15:42
@jhj0517 jhj0517 added the enhancement New feature or request label Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Word-by-word timing would be perfect for karaoke
1 participant
@jhj0517