Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor data classes #363

Merged
merged 41 commits into from
Oct 30, 2024
Merged

Refactor data classes #363

merged 41 commits into from
Oct 30, 2024

Conversation

jhj0517
Copy link
Owner

@jhj0517 jhj0517 commented Oct 30, 2024

Summarize Changes

  1. Renamed files whisper_base.py to base_transcription_pipeline.py and whisper_parameter.py to data_classes.py
  2. Several functions / classes are renamed along with change 1
  3. Separate data classes by features
  4. Use to_gradio_inputs() for each data class for gradio inputs
  5. Use WhisperImpl enum for each whisper implementation
  6. Handle None values with constants that cannot be displayed as None in the gradio UI ( See : None type initial value is not possible in gr.Textbox() gradio-app/gradio#8723)

@jhj0517 jhj0517 merged commit d4bc29b into master Oct 30, 2024
6 checks passed
@jhj0517 jhj0517 deleted the feature/refactor-models branch October 30, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant