Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add react internationalization #10639

Merged

Conversation

fabienpuissant
Copy link
Collaborator

@fabienpuissant fabienpuissant commented Aug 23, 2024

add react internationalization

create react internalization module using i18next 23.14.0 with language detector see https://react.i18next.com/latest/using-with-hooks

@CLAassistant
Copy link

CLAassistant commented Aug 23, 2024

CLA assistant check
All committers have signed the CLA.

create react internalization module using i18next 23.14.0 with language detector
see https://react.i18next.com/latest/using-with-hooks

Fix jhipster#10413
@fabienpuissant fabienpuissant force-pushed the feature/add-front-end-internationalization branch from 015f131 to aac4bfb Compare August 23, 2024 06:44
@pascalgrimaud pascalgrimaud requested a review from DamnClin August 23, 2024 07:11
@fabienpuissant fabienpuissant requested a review from murdos August 24, 2024 01:58
@murdos
Copy link
Contributor

murdos commented Aug 24, 2024

add react internationalization

Fix #10413

@DamnClin : if I'm not mistaken, your issue #10413 was more about adding i18n to the generator itself (i.e. to the application that runs jhlite)?

I think @fabienpuissant that your PR is also an interesting feature, but we should probably not close the mentioned issue:)

@fabienpuissant
Copy link
Collaborator Author

add react internationalization
Fix #10413

@DamnClin : if I'm not mistaken, your issue #10413 was more about adding i18n to the generator itself (i.e. to the application that runs jhlite)?

I think @fabienpuissant that your PR is also an interesting feature, but we should probably not close the mentioned issue:)

Yes maybe I did'nt get the point of Colin, cause I think that i18n on the front end app is a nice to have :)

@fabienpuissant fabienpuissant requested a review from murdos August 25, 2024 10:50
@murdos murdos merged commit f8efc0d into jhipster:main Aug 25, 2024
34 checks passed
@murdos
Copy link
Contributor

murdos commented Aug 25, 2024

Congrats @fabienpuissant for your first contribution! :)

@murdos murdos mentioned this pull request Aug 25, 2024
@fabienpuissant fabienpuissant deleted the feature/add-front-end-internationalization branch August 27, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants