Skip to content

Commit

Permalink
Merge pull request #11636 from qmonmert/typo261224
Browse files Browse the repository at this point in the history
Typo
  • Loading branch information
murdos authored Dec 26, 2024
2 parents 32ce72c + ac857b0 commit 30b6518
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion documentation/hexagonal-architecture.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ The very clear separation of concern enforced by the architecture eases automati
### Shorten feedback loops

In software development if you want to go faster (like really faster) you'll have to go for short feedbacks loops. If you have a button that can tell you in a few seconds that your solution is still behaving as intended you'll be way faster than checking that by hand after any update (in fact, you won't check by hand that after any update...).
In software development if you want to go faster (like really faster) you'll have to go for short feedback loops. If you have a button that can tell you in a few seconds that your solution is still behaving as intended you'll be way faster than checking that by hand after any update (in fact, you won't check by hand that after any update...).

Let's be honest here: hexagonal architecture won't help for the fastest feedback loops which are pair feedback in [pair](https://en.wikipedia.org/wiki/Pair_programming) or [mob programming](https://en.wikipedia.org/wiki/Mob_programming).

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ describe('Account Service', () => {
httpMock.expectOne({ method: 'GET' }).flush('404 error', { status: 404, statusText: 'Not Found' });
});

it('should call /account only once if last call have not returned', () => {
it('should call /account only once if last call has not returned', () => {
service.identity().subscribe();
service.identity().subscribe();
Expand Down Expand Up @@ -101,7 +101,7 @@ describe('Account Service', () => {
expect(hasAuthority).toBe(false);
});

it('should return false if user is logged and has not authority', () => {
it('should return false if user is logged and has no authority', () => {
service.authenticate(accountWithAuthorities([Authority.USER]));
const hasAuthority = service.hasAnyAuthority(Authority.ADMIN);
Expand All @@ -124,7 +124,7 @@ describe('Account Service', () => {
expect(hasAuthority).toBeFalsy();
});

it('should return false if user is logged and has not authority', () => {
it('should return false if user is logged and has no authority', () => {
service.authenticate(accountWithAuthorities([Authority.USER]));
const hasAuthority = service.hasAnyAuthority([Authority.ADMIN]);
Expand Down

0 comments on commit 30b6518

Please sign in to comment.