Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to JHipster 8.1.0 #304

Closed
wants to merge 4 commits into from
Closed

Upgrade to JHipster 8.1.0 #304

wants to merge 4 commits into from

Conversation

mraible
Copy link
Contributor

@mraible mraible commented Feb 25, 2024

No description provided.

@mraible mraible requested a review from mshima February 26, 2024 01:29
@mshima
Copy link
Member

mshima commented Feb 26, 2024

@mraible we can stop setting the version so next version don't need adjust #321.

@mraible
Copy link
Contributor Author

mraible commented Feb 26, 2024

@mshima Are you saying that your PR (#321) replaces this one? If so, where is the JHipster version set? Is it only in package.json now?

@mshima
Copy link
Member

mshima commented Feb 26, 2024

@mshima Are you saying that your PR (#321) replaces this one? If so, where is the JHipster version set? Is it only in package.json now?

It uses the default jhipsterDependenciesVersion provided by generator-jhipster.
It will match the generator-jhipster/jhipster-bom version.
A custom version was added due to v8 migration to keep v7 bom to make transition easier.

@mshima
Copy link
Member

mshima commented Feb 26, 2024

You can see the compare-sample step diff.

Captura de Tela 2024-02-26 às 14 00 47

@mraible
Copy link
Contributor Author

mraible commented Feb 26, 2024

Sounds good! Thanks for the explanation.

@mraible mraible closed this in #321 Feb 26, 2024
@mraible mraible deleted the jhipster-8.1.0 branch November 1, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants