Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds more entity types to CI (#199) #213

Merged
merged 8 commits into from
Jan 22, 2021
Merged

Adds more entity types to CI (#199) #213

merged 8 commits into from
Jan 22, 2021

Conversation

JasonTypesCodes
Copy link
Contributor

No description provided.

@atomfrede atomfrede mentioned this pull request Jan 18, 2021
13 tasks
@JasonTypesCodes JasonTypesCodes marked this pull request as ready for review January 20, 2021 22:02
@JasonTypesCodes
Copy link
Contributor Author

This is intended to close #199

As predicted by @murdos, I encountered a number of issues while attempting to pull in additional relationship types into CI. This PR addresses a handful of them.

I also opened #219 as a result of this work.

My opinion is that once this is merged, we should close #199 and replace it with more specific entity configurations that we are lacking.

@atomfrede atomfrede merged commit ffa598d into main Jan 22, 2021
@JasonTypesCodes JasonTypesCodes deleted the more-entities branch January 27, 2021 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants