Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language neutral login. #525

Open
wants to merge 1 commit into
base: 3.4
Choose a base branch
from
Open

Language neutral login. #525

wants to merge 1 commit into from

Conversation

leymannx
Copy link

Closes #524

@leymannx
Copy link
Author

leymannx commented Jan 23, 2019

Tests failing due to some Drush-related issue:

$ drush --yes --root=$PWD/drupal site-install --db-url=mysql://travis:@127.0.0.1/drupal
The program 'drush' is currently not installed. To run 'drush' please ask your administrator to install the package 'drush'
The command "drush --yes --root=$PWD/drupal site-install --db-url=mysql://travis:@127.0.0.1/drupal" failed and exited with 127 during .
Your build has been stopped.

@leymannx
Copy link
Author

Ah yo, now I found out this actually would be the start to make https://behat-drupal-extension.readthedocs.io/en/3.1/blackbox.html#override-text-strings needless. Which probably shouldn't happen in v3 anymore. But maybe in v4.

I guess this PR can get closed then. And I'll have a look into the v4 branch. 😃

@pfrenssen
Copy link
Collaborator

True this would make the password_field and username_field text overrides obsolete. I think we can deprecate it though so this could possibly still be a candidate for 3.x which is still supported.

We do prefer changes to be made first for 4.x and then backported to 3.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants