Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug where paths with spaces cause errors on build #13

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

Pxtl
Copy link
Contributor

@Pxtl Pxtl commented Oct 23, 2024

fixes bug where paths with spaces causes errors at build-time

Resolves #14

Test Evidence

https://gist.github.com/Pxtl/dc31b38cd2d1d74394a66fe6790851fb

I can now build a t4 template that includes various templates with spaces.

relevant section:

dotnet exec "C:\Users\zaratem\.nuget\packages\t4.build\0.2.4\build\../tools/T4.Build.dll" clean "Static Text Temp
         late.tt" "TextTemplate Test Withdate.tt" "TextTemplate That Reads File.tt"

@jgiannuzzi
Copy link
Owner

jgiannuzzi commented Nov 13, 2024

Thank you so much for your contribution @Pxtl!

I have just updated the CI - could you please update/rebase your branch and push it again? Never mind that, I updated your branch directly 😄

Copy link
Owner

@jgiannuzzi jgiannuzzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jgiannuzzi jgiannuzzi merged commit 9661b1f into jgiannuzzi:main Nov 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

paths with spaces cause errors
2 participants