Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support uploading code scanning alerts #203

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

RobiNino
Copy link
Contributor

@RobiNino RobiNino commented Sep 4, 2024

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • I used npm run format for formatting the code before submitting the pull request.

Depends on jfrog/jfrog-cli#2683

Running jf docker scan and jf scan commands will record sarif files which will be aggregated and uploaded to the code scanning tab in GitHub UI

Copy link
Contributor

@EyalDelarea EyalDelarea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!
Just I think the node modules can be removed from the git.

@RobiNino RobiNino merged commit 254dc2c into jfrog:master Sep 4, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants