Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 'jf' path on cleanup and validate JobSummary supported CLI version #201

Merged
merged 43 commits into from
Sep 4, 2024
Merged

Fix 'jf' path on cleanup and validate JobSummary supported CLI version #201

merged 43 commits into from
Sep 4, 2024

Conversation

sverdlov93
Copy link
Contributor

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • I used npm run format for formatting the code before submitting the pull request.

should fix #200

@sverdlov93 sverdlov93 requested a review from yahavi September 3, 2024 14:56
@sverdlov93 sverdlov93 added the safe to test Approve running integration tests on a pull request label Sep 3, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 3, 2024
@sverdlov93 sverdlov93 added the safe to test Approve running integration tests on a pull request label Sep 3, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 3, 2024
@sverdlov93 sverdlov93 added the safe to test Approve running integration tests on a pull request label Sep 3, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 3, 2024
@sverdlov93 sverdlov93 added the safe to test Approve running integration tests on a pull request label Sep 3, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 3, 2024
@sverdlov93 sverdlov93 mentioned this pull request Sep 3, 2024
Closed
@sverdlov93 sverdlov93 requested a review from yahavi September 4, 2024 13:02
@sverdlov93 sverdlov93 changed the title Fix missing 'jf' path on step cleanup Fix missing 'jf' path on step cleanup and validate JobSummary supported CLI version Sep 4, 2024
@sverdlov93 sverdlov93 changed the title Fix missing 'jf' path on step cleanup and validate JobSummary supported CLI version Fix 'jf' path on cleanup and validate JobSummary supported CLI version Sep 4, 2024
yahavi
yahavi requested changes Sep 4, 2024
View reviewed changes
src/cleanup.ts Show resolved Hide resolved
src/utils.ts Show resolved Hide resolved
src/utils.ts Show resolved Hide resolved
src/utils.ts Outdated Show resolved Hide resolved
src/cleanup.ts Outdated Show resolved Hide resolved
src/cleanup.ts Show resolved Hide resolved
@RobiNino @yahavi
Update src/cleanup.ts
e7517c9 
Co-authored-by: Yahav Itschak <[email protected]>
@RobiNino @yahavi
Update src/utils.ts
769af07 
Co-authored-by: Yahav Itschak <[email protected]>
@RobiNino RobiNino added the bug Something isn't working label Sep 4, 2024
@RobiNino RobiNino merged commit c10541d into master Sep 4, 2024
22 of 23 checks passed
@jrbushell jrbushell mentioned this pull request Sep 6, 2024
Closed
@sverdlov93 sverdlov93 deleted the fix-path-cache branch November 13, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yahavi yahavi yahavi requested changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cleanup error: Unable to find jf executable
3 participants
@sverdlov93 @yahavi @RobiNino