Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make job summary disable input schema compatible #175

Merged
merged 3 commits into from
Jul 28, 2024
Merged

Make job summary disable input schema compatible #175

merged 3 commits into from
Jul 28, 2024

Conversation

RobiNino
Copy link
Contributor

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • I used npm run format for formatting the code before submitting the pull request.

@RobiNino RobiNino added the bug Something isn't working label Jul 25, 2024
@RobiNino RobiNino requested review from eyalbe4 and yahavi July 25, 2024 09:21
@yahavi
Copy link
Member

yahavi commented Jul 25, 2024

In other Actions, GitHub uses boolean defaults:
https://github.com/actions/setup-java/blob/main/action.yml#L48
https://github.com/actions/setup-go/blob/main/action.yml#L11
https://github.com/actions/setup-node/blob/main/action.yml#L16
https://github.com/actions/setup-python/blob/main/action.yml#L17

@RobiNino RobiNino changed the title Fix job summary disable input Make job summary disable input schema compatible Jul 28, 2024
@RobiNino RobiNino merged commit 08ed366 into jfrog:master Jul 28, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 approved these changes

@yahavi yahavi Awaiting requested review from yahavi

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RobiNino @yahavi @eyalbe4