Add option to disable Job Summaries #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EyalDelarea
changed the title
yahavi
requested changes
Jul 8, 2024
EyalDelarea
commented
Jul 8, 2024
yahavi
reviewed
Jul 8, 2024
yahavi
reviewed
Jul 8, 2024
yahavi
requested changes
Jul 9, 2024
EyalDelarea
added
the
safe to test
github-actions
bot
removed
the
safe to test
EyalDelarea
added
the
safe to test
github-actions
bot
removed
the
safe to test
yahavi
approved these changes
Jul 10, 2024
…o feature_flag
EyalDelarea
added
the
safe to test
github-actions
bot
removed
the
safe to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm run formatfor formatting the code before submitting the pull request.Adding feature flag for Job Summaries.
In order to disable the creation of job summaries,
disable-job-summaryattribute can be provided the the setup CLI. default value is false.example:
Under the hood -
In order to avoid changes in the CLI itself, when the path of the output dir is not defined the CLI will ignore the recording of commands.
Therefore, when the feature flag is disabled it will just make sure to unset the output dir path.