Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve OpenID Connect integration #125

Merged
merged 3 commits into from
Jan 21, 2024
Merged

Improve OpenID Connect integration #125

merged 3 commits into from
Jan 21, 2024

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Jan 19, 2024 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • I used npm run format for formatting the code before submitting the pull request.

Enhance the OpenID Connect logic as follows:

  • Resolve Exchanging JSON web token with an access token failed: Input required and not supplied: oidc-provider-name  #121 by employing OpenID Connect exclusively when the user supplies the oidc-provider-name input.
  • In case of token exchange failure, throw an error returned from the server.
  • Clarify the documentation slightly for better understanding.
  • Make adjustments to the OpenID Connect Test subject so that it can be executed on pull requests. (the test will not be passed before merge)
  • Include a "Remove Label" action for removing the safe to test label automatically.

@yahavi yahavi added the safe to test Approve running integration tests on a pull request label Jan 19, 2024
@yahavi yahavi removed the safe to test Approve running integration tests on a pull request label Jan 19, 2024
@yahavi yahavi self-assigned this Jan 19, 2024
@yahavi yahavi added the bug Something isn't working label Jan 19, 2024
@yahavi yahavi marked this pull request as ready for review January 19, 2024 15:49
@yahavi yahavi mentioned this pull request Jan 19, 2024
Closed
sverdlov93
sverdlov93 reviewed Jan 21, 2024
View reviewed changes
Copy link
Contributor

@sverdlov93 sverdlov93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!

src/utils.ts Outdated Show resolved Hide resolved
@sverdlov93
Copy link
Contributor

also, lets update CLI default version

@yahavi yahavi merged commit 83b4c9d into jfrog:master Jan 21, 2024
10 of 11 checks passed
@yahavi yahavi added improvement Automatically generated release notes and removed bug Something isn't working labels Jan 21, 2024
@yahavi yahavi deleted the improve-oidc branch January 22, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sverdlov93 sverdlov93 sverdlov93 left review comments

@eranturgeman eranturgeman Awaiting requested review from eranturgeman

Assignees

@yahavi yahavi

Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exchanging JSON web token with an access token failed: Input required and not supplied: oidc-provider-name
2 participants
@yahavi @sverdlov93