Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating README with additional info #114

Closed
wants to merge 3 commits into from

Conversation

andrekolodochka
Copy link

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • I used npm run format for formatting the code before submitting the pull request.

Added two items:

  • It is possible to store non-sensitive data (such as connection URL, server names, etc) as configuration variables in GitHub. Unlike secrets, variables are visible and as result are easy to validate. I've updated the README with an example of how to define non-sensitive details (URL) as a variable.
  • Some commands require a connection string, such as URL and token. The examples show how to define those in a workflow step. However, if those are defined on workflow step level, they cannot be used in subsequent steps (jf docker push for example). In this case these connection details need to be defined on either workflow or job level. I've added a clarification about that.

Copy link

github-actions bot commented Nov 25, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@andrekolodochka
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@andrekolodochka
Copy link
Author

recheck

@andrekolodochka andrekolodochka marked this pull request as ready for review November 25, 2023 09:42
@eyalbe4 eyalbe4 self-requested a review November 25, 2023 09:47
@eyalbe4 eyalbe4 added the ignore for release Automatically generated release notes label Nov 25, 2023
Copy link

👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.


@eyalbe4
Copy link
Contributor

eyalbe4 commented Mar 28, 2024

@andrekolodochka,
Let us know if you'd like to continue promoting this PR.

@andrekolodochka
Copy link
Author

@eyalbe4 I've created this PR four months ago and it hasn't been merged. since then there were other changes in the master so I need to resolve those conflicts now to make the PR mergeable again. I'm happy to resolve those if the PR will be merged. but if there's another four months of waiting and resolving yet another merge conflict - no, thanks. pls let me know if I should work on resolving the merge conflicts.

@eyalbe4
Copy link
Contributor

eyalbe4 commented Apr 21, 2024

Closing this PR for now.
We may get back to implementing the improvements suggested in this PR, as well as additional improvements in the future.

@eyalbe4 eyalbe4 closed this Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore for release Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants