[ansible/artifactory/artifactory_nginx/postgres] Refactoring #398
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[ansible/artifactory]
)What this PR does / why we need it:
This PR makes the roles more maintainable by including tasks rather than duplicating them. Support for RHEL9 was added and RHEL7 was dropped (EOL June 30). artifactory_nginx_ssl role is merged in nginx. Some bugs fixed (uid/guid were never used; xray role changed the permissions of all directories under /opt/jfrog instead of /opt/jfrog/xray so for aio it was failing; crontab was disabled by default but artifactory was complaining). Creating repositories for NGINX and PostgreSQL is now optional and not enabled by default has to be enabled with:
artifactory_nginx_use_official_repos
andpostgresql_use_official_repos
. PGSQL HBA entries can be dynamically updated usingpostgresql_hba_add_inventory_hosts
. Tasks were streamlined and other fixes included to avoid issues. Platform deployment succeeds on an AIO but will ultimately fail because each service tries to use the same ports. So the serviceyaml variable will require some tuning.Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #N/A
Special notes for your reviewer:
Linted and tested on RHEL9