Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ansible/artifactory_nginx] Refactoring of the artifactory_nginx role #388

Closed
wants to merge 4 commits into from
Closed

[ansible/artifactory_nginx] Refactoring of the artifactory_nginx role #388

wants to merge 4 commits into from

Conversation

EmptyByte
Copy link

…up is now optional.

PR Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Title of the PR starts with installer/product name (e.g. [ansible/artifactory])
  • Variables and other changes are documented in the README.md
  • CHANGELOG.md updated

What this PR does / why we need it:
This PR makes the NGINX repositories setup optional. A user now needs to set the variable artifactory_nginx_setup_repos to true when they want to install/configure the NGINX official repositories. Otherwise, it does not. By default, NGINX is available in the RHEL repositories (refer to: Red Hat documentation ).

The main advantage is that we do not configure additional repositories unless requested, making it more idempotent and following user choices. Other enhancements include modularity changes and the use of distribution-based variables. This update also deprecates the artifactory_nginx_ssl role, as the new role will handle both situations.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:
Please review the changes related to the optional NGINX repository setup and the deprecation of the artifactory_nginx_ssl role. This role was not yet tested/linted and some minor correct might be required.

Copy link

github-actions bot commented Jun 13, 2024

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


EmptyByte seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

@EmptyByte
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@EmptyByte
Copy link
Author

recheck

@EmptyByte EmptyByte changed the title [ansible/artifactory_nginx] Rewok of the artifactory_nginx role [ansible/artifactory_nginx] Refactoring of the artifactory_nginx role Jun 13, 2024
@EmptyByte
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@EmptyByte EmptyByte closed this Jun 16, 2024
@EmptyByte
Copy link
Author

Will rework both nginx and postgresql.

@EmptyByte EmptyByte deleted the feature/artifactory_nginx_rework branch June 16, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant