[ansible/artifactory_nginx] Refactoring of the artifactory_nginx role #388
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…up is now optional.
PR Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[ansible/artifactory]
)What this PR does / why we need it:
This PR makes the NGINX repositories setup optional. A user now needs to set the variable artifactory_nginx_setup_repos to true when they want to install/configure the NGINX official repositories. Otherwise, it does not. By default, NGINX is available in the RHEL repositories (refer to: Red Hat documentation ).
The main advantage is that we do not configure additional repositories unless requested, making it more idempotent and following user choices. Other enhancements include modularity changes and the use of distribution-based variables. This update also deprecates the artifactory_nginx_ssl role, as the new role will handle both situations.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Please review the changes related to the optional NGINX repository setup and the deprecation of the artifactory_nginx_ssl role. This role was not yet tested/linted and some minor correct might be required.