Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ansible/artifactory] Added no_log to postgres username password assertion #374

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

AdamBrauns
Copy link
Contributor

PR Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Title of the PR starts with installer/product name (e.g. [ansible/artifactory])
  • CHANGELOG.md updated
  • Variables and other changes are documented in the README.md

What this PR does / why we need it:
Currently, the Postgres username and password are being displayed in plain text as part of the assertion task. Thus, rendering the no_log in these subsequent tasks useless.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Copy link

github-actions bot commented Feb 12, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@AdamBrauns
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@AdamBrauns
Copy link
Contributor Author

recheck

@oumkale
Copy link
Member

oumkale commented Feb 16, 2024

Hi @AdamBrauns,

Thank you for raising PR, we will take this in upcoming release.

@chukka chukka changed the base branch from master to jp-10.17.3 March 14, 2024 04:56
@chukka chukka merged commit 83ac025 into jfrog:jp-10.17.3 Mar 14, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants