Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inline image support #126

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

inline image support #126

wants to merge 2 commits into from

Conversation

adael
Copy link

@adael adael commented Mar 13, 2017

Hello I have added support to show inline images in the outgoing email (the images are shown alongside the text). IE: when you modify an issue and you paste an image using the plugin redmine_image_clipboard_paste.

I found it very useful so I wanted yo share.

Regards,

@jfqd
Copy link
Owner

jfqd commented Mar 21, 2017

Thank you for taking the time to create this pull request! I am sorry that I currently do not have the time to review it.

Would it be possible for you to fix the tests?

@adael
Copy link
Author

adael commented Mar 21, 2017

I would if I could figure out how, but it seems to be some kind of configuration error in Travis file.
It isn't because of the tests files themselves but the installer when executes bundle install to install Redmine package dependencies.

Here -> bundle install --jobs=3 --retry=3

I'm really wanted to write new tests for this feature, but I'm afraid I have no time either. Perhaps in another pull.

@vilppuvuorinen
Copy link

The Travis build has not been modified in a while now. It certainly could use a bit upgrading. Some Ruby versions in the matrix are pretty much ancient by now and later Redmine versions are not tested at all.

Fixing those could be a subject for another pull request. I feel like this is partially my fault because I initially introduced them. I'll have to see if I can conjure up some time to figure them out again.

wickyhu added a commit to wickyhu/redmine_helpdesk that referenced this pull request Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants