Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggest using optionsToDefaultConfig to generate Config from Options #268

Merged
merged 1 commit into from
Sep 5, 2020
Merged

Suggest using optionsToDefaultConfig to generate Config from Options #268

merged 1 commit into from
Sep 5, 2020

Conversation

tomjaguarpaw
Copy link
Collaborator

@tomjaguarpaw tomjaguarpaw commented Sep 5, 2020 •
edited
Loading

rather than changing the connectionOptions field of Config. Partially
addresses

#267

@tomjaguarpaw
Suggest using optionsToDefaultConfig to generate Config from Options
b0c2f51 
rather than changing the connectionOptions field of Config.  Partially
addresses

    #267
hint-man[bot]
hint-man bot approved these changes Sep 5, 2020
View reviewed changes
Copy link

@hint-man hint-man bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no place for me here... I will choose the truth I like.

@jfischoff jfischoff merged commit 8d1fe38 into master Sep 5, 2020
@jfischoff jfischoff deleted the optionsToDefaultConfig-doc branch September 5, 2020 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hint-man hint-man[bot] hint-man[bot] approved these changes

@jfischoff jfischoff jfischoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomjaguarpaw @jfischoff