catch validation errors during patch serialization #682

kiptoomm · 2018-02-06T15:33:02Z

Adds a block to catch validation exceptions that occur when PATCHing a resource

houndci-bot · 2018-02-06T15:33:11Z

tests/helpers.py

@@ -118,6 +119,28 @@ def deserialize_many(self, *args, **kw):
        """Immediately raises a :exc:`DeserializationException`."""
        raise DeserializationException

+class raise_s_validation_error(DefaultSerializer):


expected 2 blank lines, found 1

- we want to force triggering of validation exceptions during serialiation - add unit test to verify that validation exception is raised on patch - a validation exception should be raised when a validation error occurs during serialization - create a serializer class that automatically throws the validation exception - uses marshmallow's ValidationError exception, but in theory any exception could be used to force the check in order to pass them through to the flask-restless validations exceptions handler and thus have it return meaningful errors to client fix spacing issue caught by houndci

houndci-bot reviewed Feb 6, 2018

View reviewed changes

kiptoomm force-pushed the debug_validate_patch branch from 287b085 to b3788d2 Compare February 6, 2018 16:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

catch validation errors during patch serialization #682

catch validation errors during patch serialization #682

kiptoomm commented Feb 6, 2018

houndci-bot Feb 6, 2018

catch validation errors during patch serialization #682

Are you sure you want to change the base?

catch validation errors during patch serialization #682

Conversation

kiptoomm commented Feb 6, 2018

houndci-bot Feb 6, 2018

Choose a reason for hiding this comment