eve::map and callable behavior rework #2013
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SadiinsoSnowfall
force-pushed
the
map2.5
branch
from
36ee952
to
ca0d1d5
Compare
SadiinsoSnowfall
force-pushed
the
map2.5
branch
2 times, most recently
from
63c6281
to
3dbbbd6
Compare
|
It is even more files. Github fails to load 650 file diff for me. Please split it up. I believe a lot of changes are independendent. |
SadiinsoSnowfall
force-pushed
the
map2.5
branch
2 times, most recently
from
a8311aa
to
4019a32
Compare
SadiinsoSnowfall
force-pushed
the
map2.5
branch
2 times, most recently
from
f309396
to
b143360
Compare
SadiinsoSnowfall
force-pushed
the
map2.5
branch
2 times, most recently
from
4c6bab5
to
c11ea3d
Compare
SadiinsoSnowfall
force-pushed
the
map2.5
branch
from
c11ea3d
to
cc5ecb1
Compare
| EVE_FORCEINLINE constexpr T operator()(T v) const noexcept | ||
| { | ||
| return this->behavior(as<T>{}, eve::current_api, this->options(), v); | ||
| } |
There was a problem hiding this comment.
I'd argue that a _callable should deal with passing as<T> to map.
Asking all of the callers to care about it is a bit extreme.
That means that we might need some new _callable - but we can deal with that.
If the numbers confirm the perf win, I believe we should do it that way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@DenisYaroshevskiy let me know what you think