eve::abs as a demo for elementwise handling + decorator wrappings #1704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfalcou
force-pushed
the
feat/overload-abs
branch
from
fc1bdc2 to
87c5521
Compare
| << "-> abs(pf) = " << eve::abs(pf) << '\n' | ||
| << "<- pi = " << pi << '\n' | ||
| << "-> saturated(abs)(pi) = " << eve::saturated(eve::abs)(pi) << '\n' |
There was a problem hiding this comment.
why delete saturated from abs docs?
There was a problem hiding this comment.
the doc include this one AND the saturated doc, so it was redudant
| //! | ||
| //! @groupheader{Semantic Modifiers} | ||
| //! @groupheader{Semantic Modifiers} |
There was a problem hiding this comment.
should this just be one doc? upp to you, I'm just asking
There was a problem hiding this comment.
I was thinking about it, I'll try something - i.e having a single doc .cpp and use snippet inside doxygen to cut it in pieces
| @@ -9,7 +9,7 @@ int main() | |||
| wide_it pi = {-1, 2, -3, -32768}; | |||
|
|
|||
| std::cout << "---- simd" << '\n' | |||
| << "<- pi = " << pi << '\n' | |||
| << "-> saturated(abs)(pi) = " << eve::saturated(eve::abs)(pi) << '\n'; | |||
| << "<- pi = " << pi << '\n' | |||
There was a problem hiding this comment.
Do ou want to actually redo these docs as tests, since you touch them?
DenisYaroshevskiy
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.