Supports integral power in eve::powm1 and eve::pow1p

jfalcou · Sep 3, 2023 · f53e249 · f53e249
1 parent c7f4009
commit f53e249
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 6 deletions.
diff --git a/include/eve/module/math/regular/impl/pow1p.hpp b/include/eve/module/math/regular/impl/pow1p.hpp
@@ -13,12 +13,15 @@
 
 namespace eve::detail
 {
-template<floating_ordered_value T, floating_ordered_value U>
+template<floating_ordered_value T, ordered_value U>
 auto
 pow1p_(EVE_SUPPORTS(cpu_), T const& a, U const& b) noexcept
 -> decltype(pow(a, b))
 {
-  return arithmetic_call(pow1p, a, b);
+  if constexpr(integral_value<U>)
+    return pow(dec(a), b);
+  else
+    return arithmetic_call(pow1p, a, b);
 }
 
 template<floating_ordered_value T>

diff --git a/include/eve/module/math/regular/impl/powm1.hpp b/include/eve/module/math/regular/impl/powm1.hpp
@@ -13,15 +13,18 @@
 
 namespace eve::detail
 {
-template<floating_ordered_value T, floating_ordered_value U>
+template<floating_ordered_value T, ordered_value U>
 auto
 powm1_(EVE_SUPPORTS(cpu_), T const& a, U const& b) noexcept
 -> decltype(pow(a, b))
 {
-  return arithmetic_call(powm1, a, b);
+  if constexpr(integral_value<U>)
+    return dec(pow(a, b));
+  else
+    return arithmetic_call(powm1, a, b);
 }
 
-template<floating_ordered_value T>
+template<ordered_value T>
 auto
 powm1_(EVE_SUPPORTS(cpu_), T const& x, T const& y) noexcept
 {

diff --git a/test/unit/module/math/pow1p.cpp b/test/unit/module/math/pow1p.cpp
@@ -24,6 +24,8 @@ TTS_CASE_TPL("Check return types of pow1p", eve::test::simd::ieee_reals)
   TTS_EXPR_IS(eve::pow1p(v_t(), v_t()), v_t);
   TTS_EXPR_IS(eve::pow1p(T(), v_t()), T);
   TTS_EXPR_IS(eve::pow1p(v_t(), T()), T);
+  TTS_EXPR_IS(eve::pow1p(v_t(), int()), v_t);
+  TTS_EXPR_IS(eve::pow1p(T(),   int()), T);
 };
 
 //==================================================================================================

diff --git a/test/unit/module/math/powm1.cpp b/test/unit/module/math/powm1.cpp
@@ -23,7 +23,8 @@ TTS_CASE_TPL("Check return types of powm1", eve::test::simd::ieee_reals)
   TTS_EXPR_IS(eve::powm1(T(), T()), T);
   TTS_EXPR_IS(eve::powm1(v_t(), v_t()), v_t);
   TTS_EXPR_IS(eve::powm1(T(), v_t()), T);
-};
+  TTS_EXPR_IS(eve::powm1(v_t(), int()), v_t);
+  TTS_EXPR_IS(eve::powm1(T(),   int()), T);};
 
 //==================================================================================================
 // powm1  tests