feat: letter spacing #128
Open
feat: letter spacing #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeziellago
reviewed
Oct 11, 2024
| fun TextView.applyLetterSpacing(letterSpacing: TextUnit) { | ||
| if (letterSpacing != TextUnit.Unspecified) { | ||
| if (letterSpacing.isSp) { | ||
| setLetterSpacing((letterSpacing.value * 0.0624).toFloat()) |
There was a problem hiding this comment.
what 0.0624 means? where is it coming from?
There was a problem hiding this comment.
Hello, I was using a value used by others here https://chrisdavies.github.io/sp-to-em/ which seemed to be fairly consistent across screen sizes.
I've ended up using another custom solution over this project as a result of letter spacing not being consistent with existing behaviour (as a result of letter spacing only supporting EM for AndroidViews out of the box)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
letterSpacingsupport for styles.If scaled pixels value is provided, convert the value to
emso we can better use thesetLetterSpacingfunction. (Wouldn't it have been nice if it supported it out of the box!)