Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Font Family and Letter Spacing #104

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mrmichaelmoreau
Copy link

Added support for Font Family and Letter Spacing

@jeziellago
Copy link
Owner

Hi @mrmichaelmoreau, thanks for contributing!
Seems your solution conflicts with #102, where the Font Family were solved.
Could you check if that solution solves your problem? If not, could you make the adjustments needed in your PR and update the branch?

@pucamafra
Copy link
Contributor

Hey @jeziellago, there is an issue on the solution merged, we are loading the fontFamily after setting up the font weight and font style, and when we resolve the fontFamilty we are not sending them on the resolveAsTypeface method.
So, either we use the solution that @mrmichaelmoreau suggested or we invert the order we config fontStyle, fontWeight and fontFamily, something like this.
Before
image

After
image

We that even if dont pass the fontWeight and fontStyle here, we config them after on applyFontWeight and applyFontStyle.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants